Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Mitosheet default dataframe renderer gets wrong df name #1353

Open
aarondr77 opened this issue Nov 4, 2024 · 0 comments
Open

Mitosheet default dataframe renderer gets wrong df name #1353

aarondr77 opened this issue Nov 4, 2024 · 0 comments
Labels
effort: 8 type: mitosheet Changes the mitosheet package

Comments

@aarondr77
Copy link
Member

The default dataframe output Mito spreadsheet uses the the execution number to find the dataframe variable name. The assumption was that the execution number was unique in the notebook. But that is not true!

Steps to recreate.

  1. Run some code cells
  2. Restart the kernel and refresh the browser
  3. Notice that the execution #s from the previous runs are still in the notebook
  4. Run a code cell. Notice that the execution number starts back at 1.

As a result, if you create a Mito spreadsheet default renderer, it will find the last line of the first code cell with matching execution number.

To fix this, we should move away from using the execution number.

@aarondr77 aarondr77 added type: mitosheet Changes the mitosheet package effort: 8 labels Nov 4, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
effort: 8 type: mitosheet Changes the mitosheet package
Projects
None yet
Development

No branches or pull requests

1 participant