Feature request: Extend marker events

[papiliond]

Hello!

I like this project and I'm playing around with it for a few weeks now. I have a question about the Map events. In the Marker directive you didn't implement all the output event bindings. What was the reason?

Especially i am looking for a way to get 'pointerenter' event.

Thank you!

[jedsmith13]

I have added a few things but it has only been as I have needed them. I assume Milan created it because he needed it and so he probably only added those features that he needed. There isn't a lot of reason to spend lots of extra time adding features you don't need:)

I am sure if you created a PR Milan would be willing to merge it in, he has been pretty prompt when I have had changes I wanted. Also if you have any questions on implementation I could give you some direction.

[papiliond]

I see some rows commented out in map-marker.ts, such as position-changed, title-changed, ..., and also the title input (at row 143). That's why I assumed that there is something behind :)

[jedsmith13]

I am not sure about those, I believe when Milan created this he based it off some existing code that had been used for Google Maps. I would guess that they were part of that code that he didn't need.

You could try and see if they work, I don't see any reason why they shouldn't, or even why they are commented.

@mjaric Anything you want to add?

[mjaric]

Hi,
As Jedediah said above, initially this library was built to replace one that wrapped google maps, and I had idea to create common interface, so one can easily swap between different map providers. Back then, I haven't had requirement to support marker dragging on maps we rendered so those two lines commented out are just reminder to add them later. But, since I'm now on other things, I kind of put this lib aside. Fortunately Jed helped me a lot adopting building tasks to support angular>2 so it become alive again :)

Anyways, feel free to add any inputs/outputs you think it should support. Jed or I will merge it and publish to npm. Just throw some code, I'll review it and refactor it if necessary.

[papiliond]

We will see if the current implementation satisfies our needs in the future - now it really does! If this changes, I will consider a contribution to the library. Thank you!