Support and enable strict mode

[ohadschn]

I introduced the fix for #1223 (0a9ad5d) and enabled liquid strict mode again. This time I was met with the following error:

Liquid Exception: Liquid syntax error (line 21): Expected end_of_string but found pipe in "name in __names | sort" in /var/lib/gems/2.3.0/gems/minimal-mistakes-jekyll-4.5.1/_includes/group-by-array, included in _pages/category-archive.html

Perhaps you could enable liquid: error_mode: strict in the demo site's _config.yml so that once fixed, these don't slip in?

Environment information

• Minimal Mistakes version: 4.5.1
• Jekyll version: 3.5.2
• GitHub Pages hosted: no (hosted locally)
• Operating system: Bash on Ubuntu on Windows (WSL)

[mmistakes]

I fixed this already in c4ca06f for the group-by-array include in the root and under /docs. Perhaps you didn't pull down the latest /docs/_includes/group-by-array?

Testing the demo site and /test sites with error_mode: strict come out error free now.

[ohadschn]

My bad, thank you for clarifying.
Could you release a new gem version so I can update my CI with error_mode: strict?

[mmistakes]

Not ready to push a release just yet, but you don't need me to do that.

You can just pull from what's on master by replacing gem "minimal-mistakes-jekyll" in your Gemfile with the following:

gem 'minimal-mistakes-jekyll', :git => 'https://github.com/mmistakes/minimal-mistakes.git'

And if you need something more granular you can pull from specific commits, branches, tags, etc. Consult Bundler's documentation for the particulars.

[ohadschn]

Fair point, I guess I could just take the current master tip (2080469).

May I ask what is holding you from releasing a new version, and whether you have some estimation on when a new version would be released? Perhaps I'll wait too :)

[mmistakes]

Just life, my day job, family commitments, etc etc etc 😉

[ohadschn]

Ah yes, those pesky things :)

Let me rephrase - do you see any reason not to take the current master tip (2080469)?