Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bug with embedding discourse #823

Closed
4 of 5 tasks
ghutchis opened this issue Feb 8, 2017 · 1 comment
Closed
4 of 5 tasks

Bug with embedding discourse #823

ghutchis opened this issue Feb 8, 2017 · 1 comment

Comments

@ghutchis
Copy link
Contributor

ghutchis commented Feb 8, 2017

  • This is a question about using the theme.
  • I believe this to be a bug with the theme --- not Jekyll, GitHub Pages or one of the bundled plugins.
  • This is a feature request.
  • I have updated all gems with bundle update.
  • I have tested locally with bundle exec jekyll build.

Environment informations

  • Minimal Mistakes version: 4.2.1
  • github-pages or jekyll gem version: 3.4.0
  • Operating system: MacOS 10.12

Expected behavior

Based on the docs, I expect to embed Discourse comments from my server.

Steps to reproduce the behavior

See source of http://avogadro.org/news/avogadro-1-90-released/

I believe that _includes/comments.html needs a when case for "discourse"

{% when "discourse" %}
    <h4 class="page__comments-title">{{ comments_label }}</h4>
    <section id="discourse-comments"></section>

The resulting site has the embedded Discourse forum.

@mmistakes
Copy link
Owner

@ghutchis Care to submit a pull request to the develop branch with the fix?

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants