From 7fd5f5cd9d160a9b117eea48770ce4bb481f6ae6 Mon Sep 17 00:00:00 2001 From: CrazyMax <1951866+crazy-max@users.noreply.github.com> Date: Thu, 13 Feb 2025 19:03:35 +0100 Subject: [PATCH] dockerfile: error out if device feature not used in labs Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com> Signed-off-by: Tonis Tiigi --- frontend/dockerfile/dockerfile2llb/convert_norundevice.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/frontend/dockerfile/dockerfile2llb/convert_norundevice.go b/frontend/dockerfile/dockerfile2llb/convert_norundevice.go index 97a2aeef912a..86f243f98ab1 100644 --- a/frontend/dockerfile/dockerfile2llb/convert_norundevice.go +++ b/frontend/dockerfile/dockerfile2llb/convert_norundevice.go @@ -5,8 +5,12 @@ package dockerfile2llb import ( "github.com/moby/buildkit/client/llb" "github.com/moby/buildkit/frontend/dockerfile/instructions" + "github.com/pkg/errors" ) -func dispatchRunDevices(_ *instructions.RunCommand) ([]llb.RunOption, error) { +func dispatchRunDevices(c *instructions.RunCommand) ([]llb.RunOption, error) { + if len(instructions.GetDevices(c)) > 0 { + return nil, errors.Errorf("device feature is only supported in Dockerfile frontend 1.14.0-labs or later") + } return nil, nil }