Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

ESM: remove code for Node versions <10 #4736

Merged
merged 1 commit into from
Sep 4, 2021
Merged

ESM: remove code for Node versions <10 #4736

merged 1 commit into from
Sep 4, 2021

Conversation

juergba
Copy link
Contributor

@juergba juergba commented Aug 29, 2021

Description

  • remove ESM code which adressed Node versions <10
  • move lib/esm-utils.js to lib/nodejs/esm-utils.js

@juergba juergba self-assigned this Aug 29, 2021
@juergba juergba added type: chore generally involving deps, tooling, configuration, etc. area: node.js command-line-or-Node.js-specific semver-patch implementation requires increase of "patch" version number; "bug fixes" labels Aug 29, 2021
@juergba juergba requested a review from a team August 29, 2021 16:45
nicojs
nicojs approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@nicojs nicojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I guess this means a new major version?

@juergba
Copy link
Contributor Author

juergba commented Aug 30, 2021

@nicojs no, semver-patch.

We already have dropped Node v8 support with Mocha v8 more than 14 months ago.
Currently Mocha supports Node >=v12, and inofficially it still runs with Node v10.
So this PR just removes old code debris.

lib/esm-utils.js and lib/utils/supportsEsModules() are not part of a public API.

@juergba juergba merged commit 97b8470 into master Sep 4, 2021
@juergba juergba deleted the juergba/esm-debris branch September 4, 2021 08:06
@juergba juergba added this to the next milestone Sep 4, 2021
This was referenced May 21, 2024
Open
Open
Open
@leonmonson leonmonson mentioned this pull request Jul 27, 2024
Open
@federicomoneta federicomoneta mentioned this pull request Sep 9, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@outsideris outsideris outsideris approved these changes

@nicojs nicojs nicojs approved these changes

Assignees

@juergba juergba

Labels
area: node.js command-line-or-Node.js-specific semver-patch implementation requires increase of "patch" version number; "bug fixes" type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Milestone
v9.1.2
Development

Successfully merging this pull request may close these issues.
3 participants
@juergba @outsideris @nicojs