-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
🛠 Repo: Replace fs-extra with newer fs built-ins #5266
Comments
Hey - first time contributor here. I liked the idea of this kind of maintenance work and figured I could do this without reading the Contributing Guidelines but then I noticed the Since this issue doesn't have that label yet but I already did the work, I'll just leave the changeset here: main...ericcornelissen:mocha:5266-fs-extra. Happy to open a PR if that's wanted 🙂 Footnotes |
Thanks @ericcornelissen, much appreciated! I'd put it in
Ha, good catch. Up for sending a PR? I think we can skip filing an issue for a quick docs typo like that. 🙂 |
Thanks for clarifying the process. I'll keep an eye out for that and submit a PR when it switched 👍
Will do in just a moment 🙂 |
Ok @ericcornelissen I think we're good to go. Accepting PRs! 🚀 |
Tooling Suggestion Checklist
main
branch of the repository.faq
label, but none matched my issue.Overview
I ran
eslint-plugin-depend
on the Mocha repo. It had two reports aboutfs-extra
:Per https://github.com/es-tooling/module-replacements/blob/main/docs/modules/fs-extra.md:
Proposal: let's switch to native
node:fs
/node:fs/promises
.Additional Info
Note that both are within
test/integration
. This shouldn't impact users.The text was updated successfully, but these errors were encountered: