Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Review failing examples & add flags to them if it proceeds #553

Closed
98 tasks done
adpaco-aws opened this issue Oct 14, 2021 · 2 comments
Closed
98 tasks done

Review failing examples & add flags to them if it proceeds #553

adpaco-aws opened this issue Oct 14, 2021 · 2 comments
Assignees
Labels
[C] Internal Tracks some internal work. I.e.: Users should not be affected.

Comments

@adpaco-aws
Copy link
Contributor

adpaco-aws commented Oct 14, 2021

There are 98 failing examples after adding the trim-diagnostic-paths=no flag to the list of flags (this is missing in the dashboard code). We should review these examples before #517 and add flags that make them pass if possible. The list of examples is:

Checks here mean that they have been reviewed - the actual fix will come in a later PR.

@adpaco-aws adpaco-aws added Area: testing [C] Internal Tracks some internal work. I.e.: Users should not be affected. labels Oct 14, 2021
@adpaco-aws adpaco-aws self-assigned this Oct 14, 2021
@adpaco-aws
Copy link
Contributor Author

All examples in this issue have been reviewed. This first pass allowed us to group up all failures into a few ones, and adding certain flags to some examples (mostly increasing --unwind or --object-bits) is making them pass.

However, we noticed that the number of failing examples has gone up significantly (maybe because of #535). I will investigate this tomorrow and determine how to proceed.

@adpaco-aws
Copy link
Contributor Author

Marking this as blocked because of #581

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
[C] Internal Tracks some internal work. I.e.: Users should not be affected.
Projects
None yet
Development

No branches or pull requests

2 participants