Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(mf2005,mf2k): allow loading custom flopy packages #2404

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

dbrakenhoff
Copy link
Contributor

Add extra_pkgs kwarg, which updates the mfnam_packages dictionary.

- add extra_pkgs kwarg, which updates the mfnam_packages dictionary.
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.3%. Comparing base (bb9824e) to head (950e534).
Report is 34 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2404     +/-   ##
=========================================
+ Coverage     68.4%   76.3%   +7.9%     
=========================================
  Files          294     294             
  Lines        59390   59808    +418     
=========================================
+ Hits         40652   45668   +5016     
+ Misses       18738   14140   -4598     
Files with missing lines Coverage Δ
flopy/modflow/mf.py 69.3% <100.0%> (+1.2%) ⬆️

... and 245 files with indirect coverage changes

Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks useful to me.

@jdhughes-usgs
Copy link
Contributor

@dbrakenhoff Looks useful. Could you add a simple autotest?

@dbrakenhoff
Copy link
Contributor Author

test fails unrelated?

@wpbonelli
Copy link
Member

@dbrakenhoff yeah, looking into it..

@wpbonelli wpbonelli merged commit f058122 into modflowpy:develop Jan 10, 2025
19 of 23 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: support custom packages for mf2k and modflow2005
4 participants