Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Get rid of global functions #6

Closed
modularcoder opened this issue Jan 11, 2016 · 1 comment
Closed

Get rid of global functions #6

modularcoder opened this issue Jan 11, 2016 · 1 comment
Assignees
@AramManukyan
Labels
bug
Milestone
Release v1.0.0

Comments

@modularcoder
Copy link
Member

There are lot of global functions (see compiled app.js file)
We need to move most of those functions into

$(function() { });

to remove them from global scope
@modularcoder modularcoder changed the title Move global functions to $(function(){}) Get rid of global functions Jan 11, 2016
@AramManukyan
Copy link
Collaborator

Done
At this moment there are 2 global functions

  • animate
  • setSameHeights

@modularcoder modularcoder added this to the v1.0.0 milestone Feb 3, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@AramManukyan AramManukyan

Labels
bug
Projects
None yet
Milestone
Release v1.0.0
Development

No branches or pull requests
2 participants
@AramManukyan @modularcoder