Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

check user.search_users behaviour #83

Closed
ThomasWaldmann opened this issue Oct 28, 2011 · 2 comments
Closed

check user.search_users behaviour #83

ThomasWaldmann opened this issue Oct 28, 2011 · 2 comments
Labels
bug Something isn't working prio3 normal prio search / indexing / selecting
Milestone

Comments

@ThomasWaldmann
Copy link
Member

Original report by Thomas Waldmann (Bitbucket: thomaswaldmann, GitHub: thomaswaldmann).


some code is expecting it to return whoosh documents and then accessing doc[NAME] for example. this code currently fails as it returns Revisions.

some other code is dealing with it, processes the revisions correctly, e.g. by accessing rev.meta[NAME].

decide on which behaviour is correct, then fix all callers.

also check acl behaviour. access to user items might be prohibited by ACLs in a production configuration.

@ThomasWaldmann
Copy link
Member Author

Original comment by Thomas Waldmann (Bitbucket: thomaswaldmann, GitHub: thomaswaldmann).


note: changed user browser to deal with revisions returned by search_users

@ThomasWaldmann ThomasWaldmann added this to the 2.0.0b1 milestone Aug 26, 2018
@RogerHaase
Copy link
Member

Could not find any problems to fix in user.py, assume this was fixed long ago.

Found problems documented in #1707 while researching this issue.

Closing, nothing left to do.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working prio3 normal prio search / indexing / selecting
Projects
None yet
Development

No branches or pull requests

2 participants