fix: metric maintenace disappearance #1145
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/build |
|
Build and push Docker images with tag: fix-metric-maintenace-disappearance.2025-02-20.af5e136 |
HeavyPunk
reviewed
Feb 21, 2025
api/controller/trigger.go
Outdated
| for metric := range lastCheck.Metrics { | ||
| if _, ok := timeSeriesNames[metric]; !ok { | ||
| lastCheck.RemoveMetricState(metric) | ||
| modifyLastCheck := true |
There was a problem hiding this comment.
At here you can initialize variable to needed value (like at 43 line):
modifyLastCheck := len(timeSeriesNames) != 0 || metricEvaluationRulesChanged(existedTrigger, newTrigger)It would be more readable I think
There was a problem hiding this comment.
well that's reasonable, so refactored condition a bit and add comment
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix the bug, appearing in the following case:
filterSeriesIt happens because last check for the trigger is modified according to time series fetched from
now-10mintonow.This PR try to avoid unnecessary modifying last check, by checking the difference between existed and new versions of trigger (more precisely it is checked if the metrics evaluation and alerting rules have changed).