Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(NODE-5025): no type definitions for es module #563

Merged
merged 1 commit into from
Feb 16, 2023
Merged

fix(NODE-5025): no type definitions for es module #563

merged 1 commit into from
Feb 16, 2023

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

  • Updated the package.json to make the typedefs available for mjs users
  • Added a test that will prevent the order of keys from changing
  • I verified locally with my reproduction that the type defs are picked up now

What is the motivation for this change?

TS defs don't show up for module: node16/nodeNext TS users

Double check the following

  • Ran npm run lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Feb 15, 2023
@baileympearson baileympearson merged commit 50e90fc into main Feb 16, 2023
@baileympearson baileympearson deleted the NODE-5025-mjs-types branch February 16, 2023 16:50
@github-actions github-actions bot mentioned this pull request May 7, 2024
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees
No one assigned
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @baileympearson