-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: allow event loop to process during wait queue processing #2537
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Running `processWaitQueue` on the next tick allows the event loop to process while the connection pool is processing large numbers of wait queue members. NODE-2803
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but it looks like this made a test start failing in CI (unless that's unrelated)
0c92d66
to
71038b7
Compare
`endSession` must wait for all the machinery behind the scenes to check out a connection and write a message before considering its job finished.
71038b7
to
e340b8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Unfortunately this is a breaking change for anyone that uses Sinon's |
@vkarpov15 hmm, the original implementation used There's a possibility when using |
Running
processWaitQueue
on the next tick allows the event loop to process while the connection pool is processing large numbers of wait queue members.NODE-2803