Skip to content

fix: dont parse tls/ssl file paths in uri #2718

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 3 commits into from
Jan 28, 2021

Conversation

emadum
Copy link
Contributor

@emadum emadum commented Jan 26, 2021

Note: also enables our TLS test on Windows so that this fix can be verified in CI; I can split these into two PRs if desired.

NODE-2977

@emadum emadum marked this pull request as ready for review January 26, 2021 22:51
@emadum emadum requested review from nbbeeken and durran January 26, 2021 22:51
@emadum emadum force-pushed the NODE-2977/fix-tls-in-uri-option-on-windows branch from 22f7acf to 9ad4717 Compare January 27, 2021 16:01
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Member

@durran durran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants