Skip to content

fix(NODE-3176): handle errors from MessageStream #2774

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

nbbeeken
Copy link
Contributor

If there's a socket that gets a large amount of data written to it our MessageStream will throw an error about exceeding the permitted BSON size, this error is now captured in SDAM.

@nbbeeken nbbeeken marked this pull request as ready for review April 2, 2021 19:01
@nbbeeken nbbeeken requested review from durran and emadum April 2, 2021 19:01
Copy link
Contributor

@emadum emadum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice refactor 👍

@nbbeeken nbbeeken merged commit f1afcc4 into 3.6 Apr 8, 2021
@nbbeeken nbbeeken deleted the NODE-3176/3.6/catch-protocol-errors branch April 8, 2021 14:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants