Skip to content

fix: stricter protocol check in connection string #3078

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2021
Merged

fix: stricter protocol check in connection string #3078

merged 1 commit into from
Dec 13, 2021

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

Updating the connection string url parser will disallow extraneous characters infront of the mongodb:// or mongodb+srv:// portion of a connection string.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken added the Team Review Needs review from team label Dec 13, 2021
@nbbeeken nbbeeken merged commit bc05671 into main Dec 13, 2021
@nbbeeken nbbeeken deleted the chore/mongodb-connection-string-url-regex-fix branch December 13, 2021 20:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@durran durran durran approved these changes

@baileympearson baileympearson baileympearson approved these changes

@dariakp dariakp dariakp approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nbbeeken @durran @baileympearson @dariakp