Skip to content

feat(NODE-4136): revise FLE shared library typings for spec changes #3206

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2022
Merged

feat(NODE-4136): revise FLE shared library typings for spec changes #3206

merged 3 commits into from
Apr 25, 2022

Conversation

addaleax
Copy link
Contributor

Description

Typings changes for mongodb/libmongocrypt#306

What is changing?

Is there new documentation needed for these changes?

What is the motivation for this change?

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@addaleax addaleax mentioned this pull request Apr 19, 2022
Merged
addaleax
addaleax commented Apr 19, 2022
View reviewed changes
nbbeeken
nbbeeken requested changes Apr 20, 2022
View reviewed changes
@addaleax addaleax requested a review from nbbeeken April 20, 2022 15:00
@nbbeeken nbbeeken added the Team Review Needs review from team label Apr 20, 2022
nbbeeken
nbbeeken previously approved these changes Apr 20, 2022
View reviewed changes
@addaleax addaleax requested a review from nbbeeken April 21, 2022 15:57
nbbeeken
nbbeeken approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ty!

@nbbeeken nbbeeken merged commit 6e2e27f into mongodb:main Apr 25, 2022
@addaleax addaleax deleted the node-4136-dev branch April 25, 2022 15:20
@addaleax addaleax mentioned this pull request Jun 1, 2022
Merged
5 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@durran durran durran approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

@baileympearson baileympearson Awaiting requested review from baileympearson

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@addaleax @durran @nbbeeken