Skip to content

feat(NODE-4791): deprecate duplicate bulk methods #3623

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Conversation

durran
Copy link
Member

@durran durran commented Apr 4, 2023

Description

Deprecates duplicate bulk write methods.

What is changing?

  • Deprecates all the "n..." duplicate getters
  • Deprecates select duplicate getters starting with "get".
  • Updates tests to use the non-deprecated bulk properties.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-4791

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran marked this pull request as ready for review April 4, 2023 12:21
@W-A-James W-A-James self-requested a review April 4, 2023 13:50
@W-A-James W-A-James self-assigned this Apr 4, 2023
@W-A-James W-A-James added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 4, 2023
W-A-James
W-A-James previously approved these changes Apr 4, 2023
@W-A-James W-A-James added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Apr 4, 2023
@W-A-James W-A-James self-requested a review April 5, 2023 15:35
@W-A-James W-A-James merged commit 2839e95 into main Apr 5, 2023
@W-A-James W-A-James deleted the NODE-4791 branch April 5, 2023 15:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Team Review Needs review from team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants