Skip to content

feat(NODE-6338): implement client bulk write error handling #4262

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 29 commits into from
Oct 10, 2024
Merged

feat(NODE-6338): implement client bulk write error handling #4262

merged 29 commits into from
Oct 10, 2024

Conversation

durran
Copy link
Member

@durran durran commented Oct 1, 2024 •
edited
Loading

Description

Implements error handling for MongoClient#bulkWrite operations.

What is changing?

  • Unskips remaining unified tests around error handling and retries.
  • Syncs retryable-writes spec tests
  • Implements remaining CRUD prose tests around error handling.
  • Implements all required error handling per the bulk write spec.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-6338

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran force-pushed the NODE-6338-final branch 11 times, most recently from 0a55ac2 to 0355018 Compare October 3, 2024 15:57
baileympearson
baileympearson requested changes Oct 3, 2024
View reviewed changes
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 8, 2024
@nbbeeken nbbeeken self-requested a review October 8, 2024 18:41
baileympearson
baileympearson requested changes Oct 8, 2024
View reviewed changes
@durran durran requested a review from baileympearson October 8, 2024 21:37
baileympearson
baileympearson previously approved these changes Oct 9, 2024
View reviewed changes
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels Oct 9, 2024
@durran durran requested a review from nbbeeken October 9, 2024 21:04
@baileympearson baileympearson merged commit 8def42d into main Oct 10, 2024
24 of 30 checks passed
@baileympearson baileympearson deleted the NODE-6338-final branch October 10, 2024 17:48
@github-actions github-actions bot mentioned this pull request Oct 10, 2024
Merged
@shafeeqd959 shafeeqd959 mentioned this pull request Nov 11, 2024
Closed
@TartejBrothers TartejBrothers mentioned this pull request Nov 12, 2024
Merged
@akanchhaS akanchhaS mentioned this pull request Nov 12, 2024
Open
@zntb zntb mentioned this pull request Nov 12, 2024
Closed
@skanda890 skanda890 mentioned this pull request Nov 12, 2024
Merged
@thnbih thnbih mentioned this pull request Nov 12, 2024
Open
This was referenced Nov 13, 2024
Merged
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@baileympearson baileympearson baileympearson left review comments

Assignees

@baileympearson baileympearson

Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@durran @nbbeeken @baileympearson