You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you for the wonderful work on this.
Just a quick question around tags. It's written in the docs that you support tags as variable but I do not see them registered anywhere afterward (not in the Task definition, nor in the Task itself)
Should we just remove it from the README and variables.tf? Or do you want me to PR what I will do to add them to the resources?
Thank you very much!
Best regards,
The text was updated successfully, but these errors were encountered:
No problem, I actually realised what I was looking for was also to propagate tags to the task level, which is something done at the service level by the field "propagate_tags" in aws_ecs_service resources, FYI :)
Here's the PR: #48
Hi,
Thank you for the wonderful work on this.
Just a quick question around
tags
. It's written in the docs that you support tags as variable but I do not see them registered anywhere afterward (not in the Task definition, nor in the Task itself)Should we just remove it from the README and variables.tf? Or do you want me to PR what I will do to add them to the resources?
Thank you very much!
Best regards,
The text was updated successfully, but these errors were encountered: