Skip to content

Tags are not used? #47

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
g-dury opened this issue Jan 14, 2021 · 3 comments · Fixed by #48
Closed

Tags are not used? #47

g-dury opened this issue Jan 14, 2021 · 3 comments · Fixed by #48
Labels

Comments

@g-dury
Copy link
Contributor

g-dury commented Jan 14, 2021

Hi,

Thank you for the wonderful work on this.
Just a quick question around tags. It's written in the docs that you support tags as variable but I do not see them registered anywhere afterward (not in the Task definition, nor in the Task itself)
Should we just remove it from the README and variables.tf? Or do you want me to PR what I will do to add them to the resources?

Thank you very much!
Best regards,

@jasonwalsh
Copy link
Member

Hi @g-dury

Nice catch! The tags field is used by the ecs_task_definition resource, so it makes sense to add the missing field.

Would you mind submitting a PR?

Thank you.

@g-dury
Copy link
Contributor Author

g-dury commented Jan 14, 2021

Hey,

No problem, I actually realised what I was looking for was also to propagate tags to the task level, which is something done at the service level by the field "propagate_tags" in aws_ecs_service resources, FYI :)
Here's the PR: #48

@github-actions
Copy link

🎉 This issue has been resolved in version 2.1.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants