Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

v3.2.0 Script mute does not affect scripts triggered by $ #216

Open
cristianvogel opened this issue Jul 27, 2020 · 2 comments
Open

v3.2.0 Script mute does not affect scripts triggered by $ #216

cristianvogel opened this issue Jul 27, 2020 · 2 comments

Comments

@cristianvogel
Copy link

Not sure if this is a bug or intentional?

If I have a script that triggers more scripts using the $ operator, the triggered script executes even if it is muted.

@scanner-darkly
Copy link
Member

it's intentional but i'm not sure what the reasoning was for muting triggers instead of muting scripts themselves. we should update the language in the manual to reflect that.

i don't see why we can't support both though. one way we could implement it without changing the live screen UI (since it currently shows trigger mutes only) is to have a shortcut to comment out all lines in a script (something like CTRL-SHIFT-F..).

@a773music
Copy link
Contributor

How about a value of 2 mutes script triggers, 3 mutes both.

IOW binary
bit 0: mute jack triggers
bit 1: mute script triggers

00: nothing muted
01: jacks muted
10: scripts muted
11: both muted

Not sure how that should be shown on the UI, maybe:
bright = nothing muted
dimmed = one thing muted
blank= both muted

..Or if it's possible to blink, blinking could represent the 4th state.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants