Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

shim-array - global prototype modification #94

Closed
anilanar opened this issue Aug 14, 2014 · 2 comments
Closed

shim-array - global prototype modification #94

anilanar opened this issue Aug 14, 2014 · 2 comments

Comments

@anilanar
Copy link

kriskowal/q#551

Although I think naming it Array makes the most sense considering the naming convention used by the library, doesn't it break the modular nature of it by modifying a global prototype?

@kriskowal
Copy link
Member

Yes, there is certainly a tension here between one kind of modularity and another. Collections and FRB benefit from having a uniform, generic interface across all collections, so in this case, an array can be used as a Set.

@kriskowal
Copy link
Member

See #95

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants