Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Document build method #889

Open
QGarchery opened this issue Oct 17, 2024 · 0 comments · Fixed by #888
Open

Document build method #889

QGarchery opened this issue Oct 17, 2024 · 0 comments · Fixed by #888
Assignees
@QGarchery

Comments

@QGarchery
Copy link
Contributor

Note that this could be confusing for the reader, as the version it was compiled with is paris. So we could either:

  1. not change the functionality, but add a comment
  2. add a build section to make it explicit
  3. add a test section, with the downside that it will have to be used (prefixing with FOUNDRY_PROFILE=test) to make tests work

Originally posted by @QGarchery in #880 (comment)
@QGarchery QGarchery mentioned this issue Oct 17, 2024
Merged
@QGarchery QGarchery linked a pull request Oct 17, 2024 that will close this issue
Remove deprecated features #888
Merged
@QGarchery QGarchery self-assigned this Oct 17, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@QGarchery QGarchery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated features morpho-org/morpho-aavev3-optimizer
1 participant
@QGarchery