Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Write deployment script #54

Open
QGarchery opened this issue Oct 23, 2024 · 0 comments · May be fixed by #81
Open

Write deployment script #54

QGarchery opened this issue Oct 23, 2024 · 0 comments · May be fixed by #81
Assignees

Comments

@QGarchery
Copy link
Contributor

There should be some non trivial code in it, notably the code of the proxy itself.
This would make it possible to check things that need to be done right at deployment, such as using the correct ERC1967Proxy contract, passing the right dao argument to the Morpho initializer, doing the deployment in the right order, etc

@MerlinEgalite noted that it's already done in the migration tests, but would it be better if there was a script as well, to ensure that this is what will be used for deployment ?

@Jean-Grimal Jean-Grimal linked a pull request Oct 30, 2024 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants