Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Coverage is not 100% #64

Closed
MerlinEgalite opened this issue Oct 2, 2024 · 3 comments · Fixed by #74
Closed

Coverage is not 100% #64

MerlinEgalite opened this issue Oct 2, 2024 · 3 comments · Fixed by #74
Assignees
@peyha

Comments

@MerlinEgalite
Copy link
Contributor

MerlinEgalite commented Oct 2, 2024 •
edited
Loading

image
@peyha
Copy link
Collaborator

peyha commented Oct 2, 2024 •
edited
Loading

After taking a look at this issue coverage can be assessed through forge coverage --ir-minimum. Here are the current results:

Capture d’écran 2024-10-02 à 15 44 20

Note that I'll try to solve this during #20

@peyha peyha changed the title Coverage cannot be assessed Coverage is not 100% Oct 2, 2024
@peyha peyha mentioned this issue Oct 2, 2024
Closed
@peyha
Copy link
Collaborator

peyha commented Oct 2, 2024

Update: After looking at #62, it seems like the forge coverage --ir-minimum command has a weird behaviour and that the coverage is not accurate at all so we will have to use Merlin's trick to assess the coverage

@MerlinEgalite
Copy link
Contributor Author

Updated the image as it was not the correct one before

@MathisGD MathisGD linked a pull request Oct 4, 2024 that will close this issue
Test improvement #74
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@peyha peyha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test improvement morpho-org/pre-liquidation
2 participants
@MerlinEgalite @peyha