Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add return type for run #223

Open
Frikki opened this issue Oct 28, 2017 · 2 comments
Open

Add return type for run #223

Frikki opened this issue Oct 28, 2017 · 2 comments
Labels
Priority: 3 Scope: run Size: 1 Type: Discussion Type: Feature
Milestone
Revolution

Comments

@Frikki
Copy link
Member

Frikki commented Oct 28, 2017

run is missing a return type: https://github.com/motorcyclets/motorcycle/blob/c58d6fdff986fe709c07022d6036a2f1ccb5b2da/packages/run/src/run.ts#L45

It returns { sinks, sources, dispose }. It should have a type, so it’s possible to talk about it’s type signature.
@Frikki Frikki added this to the Revolution milestone Oct 28, 2017
@TylorS
Copy link
Member

TylorS commented Oct 31, 2017 •
edited
Loading

I'm thinking the name IODisposable<Sources, Sinks> would be great for this. What do you think?

@Frikki
Copy link
Member Author

Frikki commented Oct 31, 2017

Yes. I’m sold!

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Priority: 3 Scope: run Size: 1 Type: Discussion Type: Feature
Projects
None yet
Milestone
Revolution
Development

No branches or pull requests
2 participants
@Frikki @TylorS