Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Multi Language feature #207

Merged
merged 20 commits into from
Dec 10, 2024
Merged

Multi Language feature #207

merged 20 commits into from
Dec 10, 2024

Conversation

mowi12
Copy link
Owner

@mowi12 mowi12 commented Nov 20, 2024

No description provided.

@mowi12 mowi12 linked an issue Nov 20, 2024 that may be closed by this pull request
@mowi12
Copy link
Owner Author

mowi12 commented Nov 27, 2024

Title is not supported to be translated yet: facebook/docusaurus#4542

@mowi12 mowi12 force-pushed the feat/155-feature-multi-language branch 2 times, most recently from ec37d96 to acdb633 Compare November 29, 2024 10:11
@mowi12 mowi12 marked this pull request as draft November 29, 2024 13:18
@mowi12 mowi12 force-pushed the feat/155-feature-multi-language branch from acdb633 to db9f870 Compare December 1, 2024 18:06
@mowi12 mowi12 marked this pull request as ready for review December 1, 2024 18:29
@mowi12
Copy link
Owner Author

mowi12 commented Dec 1, 2024

@Slartibartfass2, Ignoriere die ganzen force pushs. Hab da nur commits reorderd und ammended.
An sich dürfte jetzt alles übersetzt sein. Bei den Tabellen musste ich die maps statisch machen, weil das sonst nicht geht.
Vielleicht findest du noch eine Lösung, aber die Docs sagen selber, dass es nur für statische Strings (variablen) geht.
Und der Tournament-Generator ist nicht übersetzbar meiner Meinung nach.

@mowi12 mowi12 force-pushed the feat/155-feature-multi-language branch from c321ad6 to 125971c Compare December 5, 2024 08:56
Copy link
Collaborator

@Slartibartfass2 Slartibartfass2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Configure config, and dropdown menus
Remove docs versioning because it is not necessary for the localization process
Update and add translations,
Remove translation of navbar title because homescreen title is not supported to be translated
Update script in order to work with the footer.
Due to the fact that some values are not static, the file has to be removed before regenerating.
After removing title in one of the last commits in order to make the homepage and navbar title consistent, this needs to be readded but with the same value as the homepage title
@mowi12 mowi12 force-pushed the feat/155-feature-multi-language branch from 125971c to 8c70be6 Compare December 10, 2024 09:15
@mowi12 mowi12 merged commit a77593d into main Dec 10, 2024
4 checks passed
@mowi12 mowi12 deleted the feat/155-feature-multi-language branch December 10, 2024 09:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Multi-Language
2 participants