-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Any way to disable/configure the "indicator"? #21
Comments
I really would like it to be a pure css thing in the theme, but I don't think the current animation would be doable. so optionally disabling it via an attribute is probably a good way to go. also people can build themes that simply do not style the indicator, because its styling is not part of the neutral basic stylesheet. |
I had an idea: could you build the current animation using |
Yes, I tried playing with the |
If the elements are laid out with flex and have equal distributed width, could the |
ah you are right, i remember, it was not the width, that was the problem, it was positioning the indicator at the selected item.. |
We should have a way to disable/hide the indicator, either via an attribute or if the WC spec still supports the crazy pseudoselector thing. |
I wanted to change the color and appearance of it and it confused me that it wasn't the bottom border of the selected tab, but a div that gets translated when the selected tab changes. Sure I can write a rule for
brick-tabbar .selected-indicator
but what I have ended up using isin order to "disable" it.
I was thinking that perhaps Brick should be more neutral in that sense and make this either an optional feature or (harder to do) convert into a CSS rendering thing only rather than an element that is floating around.
Thoughts?
The text was updated successfully, but these errors were encountered: