Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Commit

Permalink
Properly set the Photon page action's title and icon.
Browse files Browse the repository at this point in the history
Bug 1395387 changed the Photon page action API so that `title`
and `iconURL` are no longer properties but methods, setTitle()
and setIconURL().  We need to update our consumer.  Right now,
setting these properties isn't doing anything at all.
  • Loading branch information
0c0w3 committed Nov 9, 2017
1 parent 9a5a622 commit 2e15e64
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions addon/bootstrap.js
Original file line number Diff line number Diff line change
Expand Up @@ -277,10 +277,10 @@ function initPhotonPageAction(api, webExtension) {
switch (message.type) {
case "setProperties":
if (message.title) {
photonPageAction.title = message.title;
photonPageAction.setTitle(message.title);
}
if (message.iconPath) {
photonPageAction.iconURL = webExtension.extension.getURL(message.iconPath);
photonPageAction.setIconURL(webExtension.extension.getURL(message.iconPath));
}
break;
default:
Expand Down

0 comments on commit 2e15e64

Please # to comment.