Fix #2981, sanitize download filename more fully

This adds : (important on Windows), \, <, and > to the blacklist. Followup in #3083
mozilla-services · Jul 10, 2017 · af32978 · af32978
1 parent 4ae42cc
commit af32978
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/shared/shot.js b/shared/shot.js
@@ -351,7 +351,7 @@ class AbstractShot {
   get filename() {
     let filenameTitle = this.title;
     let date = new Date(this.createdDate);
-    filenameTitle = filenameTitle.replace(/[\/!@&*.|\n\r\t]/g, " ");
+    filenameTitle = filenameTitle.replace(/[:\\<>\/!@&*.|\n\r\t]/g, " ");
     filenameTitle = filenameTitle.replace(/\s{1,4000}/g, " ");
     let clipFilename = `Screenshot-${date.getFullYear()}-${date.getMonth() + 1}-${date.getDate()} ${filenameTitle}`;
     const clipFilenameBytesSize = clipFilename.length * 2; // JS STrings are UTF-16