Do not include inline JSON data if the page isn't going to be rehydrated

mozilla-services · Jan 14, 2019 · b2610e2 · b2610e2
1 parent d33477e
commit b2610e2
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/server/src/reactrender.js b/server/src/reactrender.js
@@ -64,12 +64,16 @@ exports.render = function(req, res, page) {
     const jsonString = JSON.stringify(jsonModel).replace(/\u2028/g, "\\u2028").replace(/\u2029/g, "\\u2029").replace(/<script/ig, "\\x3cscript").replace(/<\/script/ig, "\\x3c/script");
     const pageLocale = req.userLocales && req.userLocales.length > 0 ? req.userLocales[0] : "en-US";
     const pageDirection = req.isRtl ? "rtl" : "ltr";
+    let inlineJson = `<script id="json-data" type="data">${jsonString}</script>`;
+    if (page.noBrowserJavascript) {
+      inlineJson = "";
+    }
     let doc = `
     <html lang="${pageLocale}" dir="${pageDirection}">
       ${head}
       <body class="app-body">
         <div id="react-body-container">${body}</div>
-        <script id="json-data" type="data">${jsonString}</script>
+        ${inlineJson}
       </body></html>
     `.trim();
     if (!page.noBrowserJavascript) {