Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

No /contribute.json #1625

Closed
peterbe opened this issue Sep 29, 2016 · 4 comments
Closed

No /contribute.json #1625

peterbe opened this issue Sep 29, 2016 · 4 comments
Assignees
Milestone

Comments

@peterbe
Copy link

peterbe commented Sep 29, 2016

I found a bug in page shot and want to file but couldn't find it in either bugzilla or github.com/mozilla

Thanks to IRC I found this repo here.

If only there was a https://pageshot.net/contribute.json I would be able to find it. :)

@ianb
Copy link
Contributor

ianb commented Sep 29, 2016

Note the issue link is also on https://testpilot.firefox.com/experiments/page-shot – but contribute.json would be easy enough to add as well.

I'll add a separate issue for adding a GitHub link to https://pageshot.net/

@pdehaan
Copy link
Contributor

pdehaan commented Sep 29, 2016

Ref: https://www.contributejson.org/
Not sure if there'd be an easy way to auto-generate the contribute.json from our existing package.json values, or if the schema is radically different.

@ianb
Copy link
Contributor

ianb commented Sep 29, 2016

I'd be inclined to just hardcode it in server.js.

@pdehaan
Copy link
Contributor

pdehaan commented Sep 29, 2016

Wow, package.json as a contribute.json ALMOST works, apart from the odd fact that contribute.json expects a repository property to have a nested license property (whereas package.json has the license as a top-level property).

Schema snippet:

        "repository": {
            "properties": {
                "clone": {
                    "type": "string"
                },
                "license": {
                    "type": "string"
                },
                "tests": {
                    "type": "string"
                },
                "type": {
                    "type": "string"
                },
                "url": {
                    "type": "string"
                }
            },
            "required": [
                "url",
                "license"
            ],
            "type": "object"
        },

@ckprice ckprice added this to the Stretch milestone Oct 5, 2016
@ianb ianb self-assigned this Oct 6, 2016
@fzzzy fzzzy closed this as completed in 8e422a5 Oct 10, 2016
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants