Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

"upload" event action is overused #1759

Closed
ianb opened this issue Oct 17, 2016 · 0 comments
Closed

"upload" event action is overused #1759

ianb opened this issue Oct 17, 2016 · 0 comments
Assignees
Milestone

Comments

@ianb
Copy link
Contributor

ianb commented Oct 17, 2016

We're using a GA event action of "upload" for a bunch of states. This causes weird reporting.

This one puts status into eventValue, but that's weird too (elsewhere eventValue is kb):

      sendEvent("upload", "failed-status", {eventValue: response.status});

That should be a label instead. E.g., sendEvent("upload-failed",status-${response.status})

@ianb ianb added this to the Stretch milestone Oct 17, 2016
@ianb ianb self-assigned this Nov 1, 2016
@ianb ianb closed this as completed in 375cbff Nov 2, 2016
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant