This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
L20n syntax subset #3154
Merged
L20n syntax subset #3154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, review request on @6a68 once we had some more eyes on this from the pontoon side. |
|
I tested this on Pontoon stage, forking the repository in mozilla-l10n/screenshots and adding these changes, then trying to commit translations. Everything is working as expected. |
flodolo
approved these changes
Jul 20, 2017
|
@6a68 I'll go ahead and merge this one, so we can re-enable sync on Pontoon production and have a few more European hours to look out for issues. |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fluent serializers sadly don't deal gracefully with the full fluent syntax spec.
While @stasm is on vacation, let's make the server.ftl conform with the support subset.
I haven't found a better way than running the file through tools/fluentfmt.py in python-fluent, and even that only works with a local edit to serialize to utf-8.
@mathjazz, can we test this on stage in some sort?