Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Remove Add-on Version from /metrics. Closes #3609 #3656

Merged
merged 4 commits into from
Oct 20, 2017
Merged

Remove Add-on Version from /metrics. Closes #3609 #3656

merged 4 commits into from
Oct 20, 2017

Conversation

bn4t
Copy link
Contributor

@bn4t bn4t commented Oct 19, 2017

Remove Add-on Version from /metrics. Closes #3609

@bn4t bn4t changed the title Remove Add-on Version from /metrics. Closes #3609 [WIP] Remove Add-on Version from /metrics. Closes #3609 Oct 19, 2017
@bn4t bn4t changed the title [WIP] Remove Add-on Version from /metrics. Closes #3609 Remove Add-on Version from /metrics. Closes #3609 Oct 19, 2017
@bn4t
Copy link
Contributor Author

bn4t commented Oct 19, 2017

Not sure if it works 100% correctly. I unfortunately wasn't able to test it.
My installation of the server always failed with "[nodemon] failed to start process, possible issue with exec arguments".

Would be great if maybe someone could test this before merging.

@ianb
Copy link
Contributor

ianb commented Oct 20, 2017

Looks good! The nodemon thing is odd. There's a hidden option ./bin/run-server --restart that starts the server without nodemon (I guess I called it --restart because nodemon uses the option while restarting)

@ianb ianb merged commit e702b22 into mozilla-services:master Oct 20, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants