Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Upgrade query-string #4325

Closed
chenba opened this issue Apr 10, 2018 · 2 comments
Closed

Upgrade query-string #4325

chenba opened this issue Apr 10, 2018 · 2 comments
Labels
server wontfix Closed (without being fixed) because we are discontinuing the server
Milestone

Comments

@chenba
Copy link
Collaborator

chenba commented Apr 10, 2018

This is a follow-up to #4280. Upgrading query-string from 5.0.0 to 6.0.0 causes the uglifying build step to fail (!?). We need to investigate why if we want to upgrade the module.

@ghost ghost added this to the Backlog milestone Apr 12, 2018
@chenba
Copy link
Collaborator Author

chenba commented Apr 12, 2018

query-string 6.0.0 targets Node.js 6 or later, and the code was updated to use features from ES2015. Since uglify-js only support ES5, this upgrade would cause our bundling build script to fail. A solution is to babelify when we browserify. However, query-string 6.0.0 does not contain new features or fixes, so there is no urgent need to upgrade.

@ianb ianb added the server wontfix Closed (without being fixed) because we are discontinuing the server label Feb 7, 2019
@ianb
Copy link
Contributor

ianb commented Feb 7, 2019

This issue is being closed (without being fixed) because we are discontinuing the Screenshots server.

@ianb ianb closed this as completed Feb 7, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
server wontfix Closed (without being fixed) because we are discontinuing the server
Projects
None yet
Development

No branches or pull requests

2 participants