This repository has been archived by the owner on Jan 17, 2023. It is now read-only.
Fixes #5168 - Localize disconnect alert message #5169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredhirsch
suggested changes
Nov 13, 2018
locales/en-US/server.ftl
Outdated
| @@ -291,6 +291,7 @@ settingsDescription = You can # with Firefox Accounts to sync all your scr | |||
| settingsPageSubHeader = Sync & Accounts | |||
| settingsClosePreferences = | |||
| .title = Close preferences | |||
| settingsFxaDisconnectAlertMessage = Are you sure you want to disconnect this device from your Firefox account? | |||
There was a problem hiding this comment.
I think this should be 'Firefox Account', with the 'a' capitalized
jaredhirsch
changed the title
|
Marking as 'hold' until we get product feedback on the exact string, cc @johngruen |
|
String should be "Are you sure you want to disconnect this device from your Firefox Account?" with a capital A |
punamdahiya
force-pushed
the
5168-disconnect-message
branch
from
29038c7 to
71acedd
Compare
punamdahiya
changed the title
punamdahiya
force-pushed
the
5168-disconnect-message
branch
from
71acedd to
3ea1b4c
Compare
|
@flodolo Including to review localization strings in the PR. Thanks! |
flodolo
approved these changes
Nov 16, 2018
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.