Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Metrics improvements #5315

Merged
merged 2 commits into from
Jan 17, 2019
Merged

Metrics improvements #5315

merged 2 commits into from
Jan 17, 2019

Conversation

ianb
Copy link
Contributor

@ianb ianb commented Jan 15, 2019

No description provided.

ianb added 2 commits January 15, 2019 17:40
@ianb
Fix #5293, stop sending metrics if server isn't available
9bc130d 
Also adds logic to not send timing information if server is unavailable
@ianb
Fix #5264, only send analytics for 10% of users
8622f77 
This random generates a number for users when Screenshots is loaded, then saves that number, to determine who will actually send metrics.
@ianb ianb requested a review from jaredhirsch January 15, 2019 23:59
jaredhirsch
jaredhirsch approved these changes Jan 17, 2019
View reviewed changes
Copy link
Member

@jaredhirsch jaredhirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaredhirsch jaredhirsch merged commit 52bda28 into master Jan 17, 2019
@jaredhirsch jaredhirsch deleted the metrics-improvements branch January 17, 2019 15:49
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@jaredhirsch jaredhirsch jaredhirsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ianb @jaredhirsch