Default WrapFactory doesn't properly handle the isJavaPrimitiveWrap() flag

[p-bakker]

According to the JavaDoc on WrapFactory.isJavaPrimitiveWrap() the purpose of this falg is to expose Java primitives as native JavaScript primitives in JS land.

However, the code here first checks if !isJavaPrimitivateWrap() to return the object as is, but if isJavaPrimitivateWrap() == true continues onwards to call wrapAsJavaObject, which returns a NativeJavaObject.

So, IMHO, the isJavaPrimitiveWrap() is basically never properly used to wrap Java primitives as Native JavaScript objects.

Now, this you can fix by implementing your own WrapFactory, but I feel this is a bug that we should fix at some point. Is probably a breaking change that we should then slate for v2.0.0

Code below an example of not properly wrapping Java primitives > JavaScript primities

var x = new java.lang.String("");
var name = x.getClass().getName() // java.lang.String

name === 'java.lang.String' // false
name == 'java.lang.String' // true
typeof name // object
name.getClass() // class java.lang.String

[p-bakker]

Note that we also have https://github.com/mozilla/rhino/blob/399b9f05a8effd48f105afc25e7f4a5dd8ffebf7/examples/PrimitiveWrapFactory.java

[p-bakker]

I stand corrected, misinterpreted the direction of the isJavaPrimitiveWrap: needs to be set to false in order to have Java primitives exposed in JS land as native JavaScript primitives