Consstring optimization #1000
Merged
Consstring optimization #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, looks like the second part introduces a problem. have to investigate this.... |
My last commit introduces a problem in case the called method expects an object instead of a string. In this case the conversion from ConsString to String was missing. This was no problem before because of the separate conversion loop. Have added a test case for this. While investigating the issue if found another code path that leaks a ConsString into Java methods. This problem was NOT introduces by my optimization - it was there before. Have added a test for this also. Luckily the fix fixes both problems and the conversion of values from JS to Java is now more consistent.
|
Hope this is now complete - waiting for feedback. |
This was referenced Jul 23, 2021
gbrail
approved these changes
Jul 23, 2021
|
Thanks will merge this also tomorrow (if no one complains) |
p-bakker
added
the
Performance
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor optimizations
Have done the usual test with my HtmlUnit test suite a found no notable performance change. But reducing i think we have to do this to reduce the load a bit.