Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

0.7.6 includes a breaking change, but is a semver "minor". #2057

Closed
arilotter opened this issue Jan 23, 2024 · 4 comments · Fixed by #2058
Closed

0.7.6 includes a breaking change, but is a semver "minor". #2057

arilotter opened this issue Jan 23, 2024 · 4 comments · Fixed by #2058

Comments

@arilotter
Copy link
Contributor

0.7.6 adds a mandatory ttl field to the [cache.redis] section of sccache_config.

A config file that worked perfectly in 0.7.5:

[cache.redis]
url = "redis://redis.internal.devserver.local:6379/0"

In 0.7.6, now throws the error:

  sccache: error: Failed to load config file
  sccache: caused by: Failed to load toml config file from /root/.config/sccache/config
  sccache: caused by: TOML parse error at line 1, column 1
    |
  1 | [cache.redis]
    | ^^^^^^^^^^^^^
  missing field `ttl`

This makes 0.7.6 a release with breaking changes, and by semver, it should be labeled as 0.8.0, or the requirement for the ttl key should be dropped and a default used instead.

@sylvestre
Copy link
Collaborator

I didn't realize that it was a breaking change.
Sorry about that!

@sudhackar could you please have a look asap? thanks
#2027

@arilotter
Copy link
Contributor Author

@sylvestre I opened #2058 that i think fixes it

@sylvestre
Copy link
Collaborator

thanks!

@sudhackar
Copy link
Contributor

sudhackar commented Jan 23, 2024

thanks @arilotter
Sorry for this

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants