Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

sccache now tracks compiler hits/misses on a per language basis. #1895

Merged

Conversation

robertmaynard
Copy link
Collaborator

Previously sccache was actually tracking hits and misses on a compiler id basis, and guessing on the language.

This is an issue for compilers like clang which support C, C++, and CUDA. In that case we want to clearly state what language we are getting hit or misses on to help user diagnose issues.

@robertmaynard
Copy link
Collaborator Author

To properly do this I hoisted the Language type out of c.rs and made it understand Rust. I am open to other suggestions on how we can track languages across c.rs and rust.rs if others don't like this approach.

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023

Codecov Report

Attention: 72 lines in your changes are missing coverage. Please review.

Comparison is base (eb292cd) 29.83% compared to head (043d866) 29.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1895      +/-   ##
==========================================
- Coverage   29.83%   29.74%   -0.09%     
==========================================
  Files          50       50              
  Lines       17898    17967      +69     
  Branches     8624     8669      +45     
==========================================
+ Hits         5339     5344       +5     
- Misses       7407     7467      +60     
- Partials     5152     5156       +4     
Files Coverage Δ
src/compiler/c.rs 35.71% <100.00%> (-2.45%) ⬇️
src/compiler/clang.rs 53.95% <ø> (ø)
src/compiler/diab.rs 50.00% <ø> (ø)
src/compiler/msvc.rs 46.78% <ø> (-0.10%) ⬇️
src/compiler/nvcc.rs 41.17% <ø> (ø)
src/compiler/nvhpc.rs 34.09% <ø> (ø)
src/compiler/rust.rs 31.88% <100.00%> (+0.06%) ⬆️
src/compiler/tasking_vx.rs 43.63% <ø> (ø)
src/compiler/gcc.rs 57.11% <0.00%> (-0.12%) ⬇️
src/server.rs 32.00% <30.00%> (-0.13%) ⬇️
... and 2 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Previously sccache was actually tracking hits and misses on a
compiler id basis, and guessing on the language.

This is an issue for compilers like `clang` which support C, C++,
and CUDA. In that case we want to clearly state what language
we are getting hit or misses on to help user diagnose issues.
@robertmaynard robertmaynard force-pushed the bug/track_cache_hits_misses_per_language branch from 8c39367 to c31b376 Compare October 2, 2023 18:22
@sylvestre sylvestre merged commit b28d686 into mozilla:main Oct 17, 2023
@robertmaynard robertmaynard deleted the bug/track_cache_hits_misses_per_language branch October 17, 2023 12:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants