Fix off-by-one in line number replacement code #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going through the current code fails with: ``` thread 'tokio-runtime-worker' panicked at src/compiler/c.rs:687:37: source slice length (3) does not match destination slice length (2) note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ```
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1962 +/- ##
==========================================
- Coverage 29.97% 29.95% -0.03%
==========================================
Files 51 51
Lines 19152 19152
Branches 9224 9222 -2
==========================================
- Hits 5741 5737 -4
+ Misses 7958 7957 -1
- Partials 5453 5458 +5 ☔ View full report in Codecov by Sentry. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going through the current code fails with: