Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: Remove all dependences on ring 0.16 #2036

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Jan 16, 2024

Close #1442

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d1696b) 30.87% compared to head (b92dfb3) 30.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2036      +/-   ##
==========================================
- Coverage   30.87%   30.78%   -0.09%     
==========================================
  Files          51       51              
  Lines       19624    19582      -42     
  Branches     9420     9408      -12     
==========================================
- Hits         6058     6028      -30     
+ Misses       7876     7845      -31     
- Partials     5690     5709      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lysliu
Copy link

lysliu commented Jan 16, 2024

This PR works on s390x

warning: unused import: `self::toolchain_imp::*`
  --> src/dist/pkg.rs:23:9
   |
23 | pub use self::toolchain_imp::*;
   |         ^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: `sccache` (lib) generated 1 warning (run `cargo fix --lib -p sccache` to apply 1 suggestion)
    Finished dev [unoptimized + debuginfo] target(s) in 1m 04s

I can get a s390x binary after success build


-rwxr-x---   2 root root 424883184 Jan 16 08:05 sccache*
-rw-r-----   1 root root      1471 Jan 16 08:05 sccache.d
root@zenv:~/sccache/target/debug# ./sccache --version
sccache 0.7.5
root@zenv:~/sccache/target/debug# uname -m
s390x

@sylvestre
Copy link
Collaborator

excellent, thanks

@sylvestre sylvestre merged commit 0ef1a54 into mozilla:main Jan 16, 2024
48 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sccache fails to build on s390x because of ring
4 participants