Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add default ttl of 0 to fix breaking change #2058

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

arilotter
Copy link
Contributor

closes #2057

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (19c55bd) 30.86% compared to head (665cf67) 30.72%.

Files Patch % Lines
src/config.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2058      +/-   ##
==========================================
- Coverage   30.86%   30.72%   -0.15%     
==========================================
  Files          52       52              
  Lines       19717    19717              
  Branches     9488     9491       +3     
==========================================
- Hits         6086     6058      -28     
- Misses       7910     7923      +13     
- Partials     5721     5736      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre
Copy link
Collaborator

it would be nice to have a test to make sure we don't regress in the future!

@sylvestre sylvestre merged commit 22f5a0a into mozilla:main Jan 23, 2024
48 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.7.6 includes a breaking change, but is a semver "minor".
3 participants