Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Rewrite Redis environment variables API #2116

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

AJIOB
Copy link
Contributor

@AJIOB AJIOB commented Mar 2, 2024

  • Implement Redis configuration values splitting support
  • Actualize Redis main docs
  • Actualize configuration docs
  • Use both old & new Redis API for tests

Fix #2083

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 56.41%. Comparing base (0cc0c62) to head (9424a81).
Report is 4 commits behind head on main.

Files Patch % Lines
src/config.rs 66.66% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2116       +/-   ##
===========================================
+ Coverage   30.91%   56.41%   +25.50%     
===========================================
  Files          53       53               
  Lines       20112    20338      +226     
  Branches     9755     9791       +36     
===========================================
+ Hits         6217    11474     +5257     
+ Misses       7922     7591      -331     
+ Partials     5973     1273     -4700     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AJIOB AJIOB force-pushed the AJIOB/redis-rewrite-env-api branch from db28570 to 7ad9338 Compare March 2, 2024 21:09
@AJIOB AJIOB marked this pull request as ready for review March 2, 2024 21:09
* Actualize Redis main docs
* Actualize configuration docs
* Use both old & new Redis API for tests
@AJIOB AJIOB force-pushed the AJIOB/redis-rewrite-env-api branch from 7ad9338 to 9424a81 Compare March 3, 2024 11:31
Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the tests!

@Xuanwo Xuanwo merged commit 677bcc8 into mozilla:main Mar 3, 2024
51 checks passed
@AJIOB AJIOB deleted the AJIOB/redis-rewrite-env-api branch March 3, 2024 12:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store Redis username & password in a dedicated environment variables
3 participants