WIP: Add option to skip RW mode check #2133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvestre
reviewed
Mar 15, 2024
docs/Configuration.md
Outdated
| @@ -3,6 +3,9 @@ | |||
| ## file | |||
|
|
|||
| ```toml | |||
| # If specified, wait this long for the server to start up. | |||
There was a problem hiding this comment.
don't hesitate to do this into a different PR as it is unrelated
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2133 +/- ##
===========================================
+ Coverage 30.91% 42.28% +11.37%
===========================================
Files 53 53
Lines 20112 20653 +541
Branches 9755 9962 +207
===========================================
+ Hits 6217 8734 +2517
+ Misses 7922 7911 -11
+ Partials 5973 4008 -1965 ☔ View full report in Codecov by Sentry. |
Xuanwo
approved these changes
Mar 17, 2024
|
indeed, it will need some tests before merging this PR! |
In the config, `cache.assume_rw_mode`; in the environment, `SCCACHE_ASSUME_RW_MODE`. The "winning" value, if any is specified, will cause the server to skip the read/write `check` of the remote backend and assume that it operates in the given mode.
|
still draft for a while |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: I've not tested this yet.
Adds a config / env option,
cache.assume_rw_modeorSCCACHE_ASSUME_RW_MODE. If present, the server skips the startup check of the cache's mode, and assumes it is the one specified. If not present, the server attempts to read and write from the server, and uses the results to determine the mode.Fixes #2132 (I think - again, I need to work out how to test this properly before sending forward).