Disable preprocessor cache with -MD and friends #2195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also hook up too_hard_for_preprocessor_cache_mode, because it wasn't.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2195 +/- ##
===========================================
+ Coverage 30.91% 42.55% +11.64%
===========================================
Files 53 53
Lines 20112 20328 +216
Branches 9755 9684 -71
===========================================
+ Hits 6217 8650 +2433
- Misses 7922 7976 +54
+ Partials 5973 3702 -2271 ☔ View full report in Codecov by Sentry. |
sylvestre
reviewed
May 29, 2024
| preprocessor_cache_mode_config, | ||
| )? | ||
| } else { | ||
| None |
There was a problem hiding this comment.
could you please add a log entry here ? might be hard to debug otherwise for people who might want to use it
There was a problem hiding this comment.
That would need to mention what specifically makes it too hard for the preprocessor cache, though, otherwise the log is not going to be useful (like cannot_cache!). Maybe more of a followup?
There was a problem hiding this comment.
Done in #2197. I'll rebase this one when that one is merged.
glandium
added a commit
to glandium/sccache
that referenced
this pull request
Jan 28, 2025
sccache has two modes: - normal mode - preprocessor cache mode (aka direct mode in ccache) In the former case, the preprocessor is invoked and creates the dep file itself. Whatever sccache does after that is going to overwrite a fresh file with potentially wrong information, since the cache key is not indexed on the elements that would affect the contents of the dep file, resulting in issue mozilla#2321. In the latter case, sccache currently doesn't handle the situation appropriately (issue mozilla#2194), which is why preprocessor cache mode is automatically disabled when the dependency flags are on the command line (mozilla#2195). Which also means we fallback to the case above.
Merged
glandium
added a commit
to glandium/sccache
that referenced
this pull request
Jan 28, 2025
sccache has two modes: - normal mode - preprocessor cache mode (aka direct mode in ccache) In the former case, the preprocessor is invoked and creates the dep file itself. Whatever sccache does after that is going to overwrite a fresh file with potentially wrong information, since the cache key is not indexed on the elements that would affect the contents of the dep file, resulting in issue mozilla#2321. In the latter case, sccache currently doesn't handle the situation appropriately (issue mozilla#2194), which is why preprocessor cache mode is automatically disabled when the dependency flags are on the command line (mozilla#2195). Which also means we fallback to the case above.
sylvestre
pushed a commit
that referenced
this pull request
Jan 30, 2025
sccache has two modes: - normal mode - preprocessor cache mode (aka direct mode in ccache) In the former case, the preprocessor is invoked and creates the dep file itself. Whatever sccache does after that is going to overwrite a fresh file with potentially wrong information, since the cache key is not indexed on the elements that would affect the contents of the dep file, resulting in issue #2321. In the latter case, sccache currently doesn't handle the situation appropriately (issue #2194), which is why preprocessor cache mode is automatically disabled when the dependency flags are on the command line (#2195). Which also means we fallback to the case above.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also hook up too_hard_for_preprocessor_cache_mode, because it wasn't.