Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add windows arm64 to the CI #2243

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

hjyamauchi
Copy link
Contributor

No description provided.

@hjyamauchi
Copy link
Contributor Author

CC @Xuanwo

@hjyamauchi
Copy link
Contributor Author

This is based on the discussion #2223

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.65%. Comparing base (0cc0c62) to head (1e5e1d7).
Report is 70 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2243       +/-   ##
===========================================
+ Coverage   30.91%   51.65%   +20.74%     
===========================================
  Files          53       55        +2     
  Lines       20112    20717      +605     
  Branches     9755     9776       +21     
===========================================
+ Hits         6217    10701     +4484     
- Misses       7922     8025      +103     
+ Partials     5973     1991     -3982     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre
Copy link
Collaborator

AFAIK, it is building but not running tests, am I correct?

@hjyamauchi
Copy link
Contributor Author

I didn't realize there was a test step. So, I believe so. Do we want to enable testing?

@hjyamauchi
Copy link
Contributor Author

AFAICT, windows arm64 runners aren't available on github yet. So testing for windows arm64 isn't currently viable?

@sylvestre
Copy link
Collaborator

correct but not an issue :)

@sylvestre sylvestre merged commit 95455ad into mozilla:main Aug 7, 2024
55 checks passed
@hjyamauchi
Copy link
Contributor Author

@sylvestre Great, thank you!
Do you have an idea when the next release that includes a windows arm64 binary may happen?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants